[Webkit-unassigned] [Bug 36003] Enhance GTK DRT implementation to support platform scroll wheel events.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 13:04:23 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=36003
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146016|review? |review-
Flag| |
--- Comment #3 from Martin Robinson <mrobinson at webkit.org> 2012-06-26 13:04:20 PST ---
(From update of attachment 146016)
View in context: https://bugs.webkit.org/attachment.cgi?id=146016&action=review
Looks good, just a few style nits. Can't we unskip some tests now?
> Tools/DumpRenderTree/gtk/EventSender.cpp:483
> + int horizontal = (int)JSValueToNumber(context, arguments[0], exception);
> + g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));
> + int vertical = (int)JSValueToNumber(context, arguments[1], exception);
> + g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));
You should use static_cast here instead of C-style casts. Is it possible to just elminate the cast entirely here?
> Tools/DumpRenderTree/gtk/EventSender.cpp:487
> + gboolean paged = false;
> + if (argumentCount == 3) {
> + paged = JSValueToBoolean(context, arguments[2]);
bool intead of gboolean would be more appropriate here. Why does paged need to be defined in outer scope? Seems like this could just be:
g_return_val_if_fail(argumentcount < 3 || !JSValueToBoolean(context, arguments[2]), JSValueMakeUndefined(context));
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list