[Webkit-unassigned] [Bug 89989] New: Chromium WebSocket tests fail due to Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89989

           Summary: Chromium WebSocket tests fail due to
                    Tools/Scripts/webkitpy/layout_tests/port/chromium_win.
                    py
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: wez at chromium.org
                CC: tony at chromium.org


When WebKit r121194 was rolled in to Chromium the WebSocket tests started failing due to a version-check preventing the WebSocket test server from running, e.g:

ExtensionApiTest.WebSocket: 
Traceback (most recent call last):
  File "e:\b\build\slave\Vista_Tests__1_\build\src\third_party\WebKit\Tools\Scripts\new-run-webkit-websocketserver", line 115, in <module>
    main()
  File "e:\b\build\slave\Vista_Tests__1_\build\src\third_party\WebKit\Tools\Scripts\new-run-webkit-websocketserver", line 101, in main
    port_obj = host.port_factory.get(port_name='chromium', options=options)
  File "e:\b\build\slave\Vista_Tests__1_\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\factory.py", line 117, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "e:\b\build\slave\Vista_Tests__1_\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\chromium_win.py", line 81, in __init__
    assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (self._version, self.SUPPORTED_VERSIONS)
AssertionError: vista is not in ('xp', 'win7')
[4820:3220:0626/083523:641062:ERROR:ui_test_utils.cc(940)] Failed to run new-run-webkit-websocketserver: wait_success = 1, exit_code = 1
browser\extensions\extension_websocket_apitest.cc(13): error: Value of: StartWebSocketServer(websocket_root_dir)
  Actual: false
Expected: true

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.