[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149490|review?                     |review-
               Flag|                            |




--- Comment #31 from Yury Semikhatsky <yurys at chromium.org>  2012-06-26 05:02:08 PST ---
(From update of attachment 149490)
View in context: https://bugs.webkit.org/attachment.cgi?id=149490&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:136
> +    if (m_currentSourceID != sourceID) {

Can you explain how that is expected to work in case when you first stop in a script 1, then in a script 2 and again in the same line in script 1? It seems that in that case you will return the first column as the current one or am I missing something?

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:157
> +    int nextColumn = codeInLine.find(";", m_currentStatementPosition.columnNumber);

You shouldn't be trying to parse the code here, instead JSC should be extended to report you current statement's column.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:160
> +        if (c == ' ' || c == '\t')

What is the purpose of skipping first whitespace?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.