[Webkit-unassigned] [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89735





--- Comment #15 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-06-26 04:42:51 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 149447 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=149447&action=review
> > 
> > > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:278
> > > +        for (var i = 0; i < this.watchExpressions.length; ++i)
> > 
> > style nit: {} around multiline body
> 
> Thanks Yury for the review. I was intending to use the same styling as you proposed, but noticed that the function just above it "findAddedTreeElement" also omitted the braces. So to keep the code consistent, I omitted the braces as well.
> So should I change it?

While Yury is away, please let me take liberty and suggest that you fix findAddedTreeElement() and saveExpressions(), too. Both of them exhibit this bad style and must be just a long-standing legacy code. In all reasonable cases we stick to the coding guidelines found at http://www.webkit.org/coding/coding-style.html (and this particular case is covered by http://www.webkit.org/coding/coding-style.html#braces-blocks).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.