[Webkit-unassigned] [Bug 89872] [WK2] Add new C API to generate MHTML data from the UI process
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 00:36:40 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=89872
Mario Sanchez Prada <msanchez at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #149289|0 |1
is obsolete| |
Attachment #149472| |review?
Flag| |
--- Comment #7 from Mario Sanchez Prada <msanchez at igalia.com> 2012-06-26 00:36:39 PST ---
Created an attachment (id=149472)
--> (https://bugs.webkit.org/attachment.cgi?id=149472&action=review)
Patch proposal
(In reply to comment #6)
> (From update of attachment 149289 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149289&action=review
>
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:602
> > + WKPageGetContentsAsMHTMLData(pageRef, callGetContentsAsMHTMLDataBlockAndDispose, Block_copy(block));
>
> You are missing the bool useBinaryEncoding parameter here. And the order is context, callback, you are passing the callback before the context.
Ah! That explains things. Attaching a new patch
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list