[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88631


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147743|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-25 20:56:31 PST ---
(From update of attachment 147743)
View in context: https://bugs.webkit.org/attachment.cgi?id=147743&action=review

Set '-' because above comments.

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:29
> +using namespace WebCore;

I wonder why do you add WebCore namespace. I can't find WebCore usage in this file.

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:31
> +static Ewk_View_Smart_Class g_parentSmartClass = EWK_VIEW_SMART_CLASS_INIT_NULL;

g_ is GTK port style. Please keep to consistent with WK1 EFL style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.