[Webkit-unassigned] [Bug 86707] document.activeElement should not return an element not in the document tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86707


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149258|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #3 from Kent Tamura <tkent at chromium.org>  2012-06-25 20:47:48 PST ---
(From update of attachment 149258)
View in context: https://bugs.webkit.org/attachment.cgi?id=149258&action=review

>> Source/WebCore/dom/Document.cpp:3769
>> +    if (newFocusedNode && newFocusedNode->attached()) {
> 
> Using Node::inDocument() would be preferred in this case. attached() has slightly different semantics.

We should use Node::isFocusable() and/or Node::supportsFocus().
e.g. <input disabled> shouldn't have focus.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.