[Webkit-unassigned] [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89735





--- Comment #11 from Rahul Tiwari <rahultiwari.cse.iitr at gmail.com>  2012-06-25 20:43:41 PST ---
(In reply to comment #10)
> (From update of attachment 149261 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149261&action=review
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:263
> > +        this.watchExpressions.splice(0, expressionlength);
> 
> this.watchExpressions = []; ?
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:278
> > +        var count= 0;
> 
> spaces around "="
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:279
> > +        for (var i = 0; i < this.watchExpressions.length; ++i){
> 
> spaces between "){"
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:379
> > +       var expressioncount= this.treeOutline.section._expressionCount();
> 
> spaces; expressioncount => expressionCount
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:381
> > +            contextMenu.appendItem(WebInspector.UIString("Delete all watch expressions"), this._deleteAllExpressions.bind(this));
> 
> wrong indent

Thanks Andrey for the review. I will make the changes and post the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.