[Webkit-unassigned] [Bug 89867] [Texmap] Remove platform specific code in BitmapImageGL::updateContents by using GraphicsContext3D::extractImageData.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89867





--- Comment #12 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-06-25 18:20:13 PST ---
(From update of attachment 149398)
View in context: https://bugs.webkit.org/attachment.cgi?id=149398&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:523
> +    // The premultiplyAlpha is true, because the default value of alphaOption in ImageSource is AlphaPremultiplied.
> +    bool premultiplyAlpha = true;
> +    // The ignoreGammaAndColorProfile is false, because the default value of gammaAndColorProfileOption in ImageSource is GammaAndColorProfileApplied.
> +    bool ignoreGammaAndColorProfile = false;
> +    GraphicsContext3D::extractImageData(image, GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, flipY, premultiplyAlpha, ignoreGammaAndColorProfile, imageData);

Not exactly what I meant...
something like: GraphicsContext3D::extractImageData(image, GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, flipY, true /* premultiplyAlpha */, false /* ignoreGammaAndColorProfile */, imageData);
this way there are no magic "false" and "true" around.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.