[Webkit-unassigned] [Bug 89620] fast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 13:49:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89620





--- Comment #6 from Alexis Menard (darktears) <alexis.menard at openbossa.org>  2012-06-25 13:49:19 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Alexis, please take a look.
> 
> I will as soon as I get my hands on a Mac (monday).
> 
> As http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r120838%20(351)/fast/box-decoration-break/box-decoration-break-rendering-diffs.html
> 
> it's hard to see any difference. I will try to figure out what is going on.
> 
> Funny enough (or not) http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r120838%20(351)/fast/box-decoration-break/box-decoration-break-rendering-diff.png shows differences for the slice case, which is the default one of box-decoration-break, i.e the behavior we had before, so it doesn't use the new code path at all.

I looked at the differences and unlike all other ports Mac behave differently when it comes to border-radius.

If you look the attached image what the ref file is trying to reproduce is the right and left "cut" border-radius/border/shadow which happen when we layout a box in multiple lines. This is the box-decoration-break: slice case, which is the default case we always had in the past.

I declare the ref test like this :

#rightCutHighlight {
        display: inline;
        border-top: 2px solid red;
        border-right: 0px solid red;
        border-left: 2px solid red;
        border-bottom: 2px solid red;
        border-top-left-radius: 4px;
        border-top-right-radius: 0px;
        border-bottom-right-radius: 0px;
        border-bottom-left-radius: 4px;
        background: yellow;
        box-shadow: 0px 1px 3px dimgrey;
    }

which reproduce the same effect as the cut, at least semantically.

While this render exactly the same as the reference on Chromium, Qt, and GTK the radius renders differently on Mac. The anti-aliasing (or maybe the drawing itself) is 1 or 2 pixels different from the original file.

I noticed that if I change border-right: 0px solid red; to border-right: 2px solid white; I have no visual difference as well as no image difference. Therefore it seems that the drawing of the radius for some reason is influenced by the total size of the box (which I believe it shouldn't).

That's all for now. I will try to figure out how the radius is drawn in the Mac port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list