[Webkit-unassigned] [Bug 89759] [CSSRegions]Change display values that allow regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89759





--- Comment #3 from Andrei Onea <onea at adobe.com>  2012-06-25 08:55:16 PST ---
> Are there existing tests for changing the display type dynamically in javascript? Do we properly re-create the RenderObject in that case?
Not yet. I will add a test in the next iteration of the patch. The RenderObject, however, is always recreated when changing the display property value. (Node::diff checks for different display values, and forces the node to detach when they are different).

> > Source/WebCore/ChangeLog:9
> > +        Allow only elements with display values of block, inline-block,
> > +        table-cell, table-caption and list-item to become regions.
> 
> Can you include a link to the spec here?

Will do.

> > Source/WebCore/rendering/style/RenderStyle.h:1511
> > +    { // Only non-replaced block elements can become a region.
> > +        return display() == BLOCK || display() == INLINE_BLOCK
> > +            || display() == TABLE_CELL || display() == TABLE_CAPTION
> > +            || display() == LIST_ITEM;
> 
> What about table, box, flexbox, grid and their inline versions?

I'm not sure about that yet, I will come back on it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.