[Webkit-unassigned] [Bug 89837] [WK2][Qt][EFL] Extract common code from LayerTreeHostQt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89837


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149231|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-06-24 21:23:31 PST ---
(From update of attachment 149231)
View in context: https://bugs.webkit.org/attachment.cgi?id=149231&action=review

LayerTreeHostWeb doesn't fit with the rest of the names around.
How about we create a LayerTreeCoordinator directory under WebProcess/WebPage, and also move WebGraphicsLayer under that directory? We should rename LayerTreeHostProxy to LayerTreeCoordinatorProxy while we're at it.

> Source/WebKit2/WebProcess/WebPage/web/qt/LayerTreeHostQt.h:38
> +class LayerTreeHostQt : public LayerTreeHostWeb {
> +public:
> +    static PassRefPtr<LayerTreeHostQt> create(WebPage*);
> +    virtual ~LayerTreeHostQt();
> +
> +    virtual int64_t directlyCompositedImageKey(WebCore::Image*);
> +
> +private:
> +    explicit LayerTreeHostQt(WebPage*);
> +};

Virtualizing for this seems like an overkill... I'd rather have non-virtual functions, and implement directlyCompositedImageKey inside a platform-specific #ifdef.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.