[Webkit-unassigned] [Bug 89828] Optimize RenderGeometryMap mappings gathering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89828





--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-06-24 14:53:17 PST ---
(From update of attachment 149194)
View in context: https://bugs.webkit.org/attachment.cgi?id=149194&action=review

> Source/WebCore/rendering/RenderGeometryMap.cpp:182
> +    if (ancestorLayer && layer->canUseConvertToLayerCoords() && renderer->style()->position() != FixedPosition) {

Doesn't this need to check canUseConvertToLayerCoords() on all layers between layer and ancestorLayer? There's no guarantee that ancestorLayer is an immediate ancestor.

> Source/WebCore/rendering/RenderGeometryMap.h:52
> +    // Called by code walking the layer tree.
> +    void pushMappingsToAncestor(const RenderLayer*, const RenderLayer* ancestorLayer);
> +    void popMappingsToAncestor(const RenderLayer*);

I'd like to keep versions that are renderer-based, so we can call them from absoluteRects()/absoluteQuads() at some point (we already know of cases where these are a bottleneck).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.