[Webkit-unassigned] [Bug 82560] Implement canvas v5 line dash feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 24 08:00:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82560





--- Comment #13 from Tim Horton <timothy_horton at apple.com>  2012-06-24 08:00:51 PST ---
(From update of attachment 134707)
View in context: https://bugs.webkit.org/attachment.cgi?id=134707&action=review

> Source/WebCore/ChangeLog:8
> +

Can you explain here what's different from the old behavior?

Also, I believe that keeping the old behavior (and implementing the new one under the unprefixed name) is the right thing to do.

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:106
> +JSValue JSCanvasRenderingContext2D::setLineDash(ExecState* exec)

Why does this return a value that is always jsUndefined now?

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:491
> +    if ((dash.size() % 2) == 1)

I don't think the == 1 is necessary.

> LayoutTests/ChangeLog:8
> +

I'm not positive, but I think you should test both the old prefixed behavior and the new behavior. Is there a test of the new odd-length-dash-array doubling behavior?

> LayoutTests/fast/canvas/canvas-lineDash-expected.txt:12
> +PASS lineDash[2] is 15

I guess so.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list