[Webkit-unassigned] [Bug 89719] [EFL] ProcessExecutablePath is required

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89719





--- Comment #5 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-06-23 13:41:13 PST ---
(From update of attachment 148924)
View in context: https://bugs.webkit.org/attachment.cgi?id=148924&action=review

I don't really understand the need for this patch. The functions being implemented here are only used by the Qt and GTK+ WebKit2 ports, so assuming we're using them for the same purpose, the UIProcess/Launcher/efl/ProcessLauncherEfl.cpp side should be changed as well. And in this case, I don't understand why these low-level calls and Linux-only semantics are being used instead of ecore_exe_run(), both here and in ProcessLauncherEfl.cpp itself.

>>> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:28
>>> +const char* gWebKitWebProcessName = "WebProcess";
>> 
>> I prefer to use "static const char*" for constant variable.
> 
> One more thing, gXXX is gtk style. Just use webkitWebProcessName.

`static const char foo[]' is even better, since it is placed in the .rodata section. Ideally, this should be defined at configure-time in CMake and put into cmakeconfig.h.in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.