[Webkit-unassigned] [Bug 89639] [EFL] Change format of return value of navigator.language

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89639





--- Comment #11 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-06-23 12:40:24 PST ---
(From update of attachment 149154)
View in context: https://bugs.webkit.org/attachment.cgi?id=149154&action=review

> Source/WebCore/ChangeLog:8
> +        Change format of return value of navigator.language from xx-XX.UTF-8 to xx-XX.

You need to explain why you are doing this. Please also note that 'UTF-8' is not hardcoded, it just happens to be the encoding you are using on your system. A more generic description would be along the lines of "Remove the encoding from the language returned by navigator.language".

The `language' attribute of the navigator object does not seem to be part of any standard, so different browsers seem to return different values anyway. Do you know if "en-US" is currently more common than "en", for example?

> Source/WebCore/ChangeLog:9
> +        Need a short description and bug URL (OOPS!)

Wrong line.

> Source/WebCore/ChangeLog:11
> +        Test: platform/efl/fast/js/navigator-language.html

I object to copying this test from Qt; it was moved to platform/qt in r113892 because it apparently tested something which was relevant only to that port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.