[Webkit-unassigned] [Bug 89733] Figure out why FrameView.cpp's ASSERT(!needsLayout()) is firing in chromium & chromium's DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89733


Ami Fischman <fischman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Drop inappropriate          |Figure out why
                   |ASSERT(!needsLayout()) in   |FrameView.cpp's
                   |FrameView.cpp               |ASSERT(!needsLayout()) is
                   |                            |firing in chromium &
                   |                            |chromium's DRT
                 CC|                            |fischman at chromium.org




--- Comment #3 from Ami Fischman <fischman at chromium.org>  2012-06-22 21:39:08 PST ---
(In reply to comment #2)
> That assertion is there for a reason. We should never be painting if layout is not up-to-date. There should be mechanisms that ensure that (viewWillDraw in WK1 etc).

Thanks for the info, Simon!

Searching blindly for viewWillDraw (since I know next to nothing about the code in question) led me to http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/mac/WebView/WebHTMLView.mm&exact_package=chromium&q=viewWillDraw&l=1313 which makes me wonder if some of those "known cases where -viewWillDraw is not called on all views being drawn" are the problem chromium is tripping over (without compensating logic like that WebHTMLView.mm code).  Do you know what that comment is about and whether it is likely ir/relevant to the chromium bug?
(or, does anything in the stacktrace in http://code.google.com/p/chromium/issues/detail?id=128776#c5 ring a bell?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.