[Webkit-unassigned] [Bug 89759] [CSSRegions]Change display values that allow regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89759


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149034|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Tony Chang <tony at chromium.org>  2012-06-22 15:36:38 PST ---
(From update of attachment 149034)
View in context: https://bugs.webkit.org/attachment.cgi?id=149034&action=review

Are there existing tests for changing the display type dynamically in javascript? Do we properly re-create the RenderObject in that case?

> Source/WebCore/ChangeLog:9
> +        Allow only elements with display values of block, inline-block,
> +        table-cell, table-caption and list-item to become regions.

Can you include a link to the spec here?

> Source/WebCore/rendering/style/RenderStyle.h:1511
> +    { // Only non-replaced block elements can become a region.
> +        return display() == BLOCK || display() == INLINE_BLOCK
> +            || display() == TABLE_CELL || display() == TABLE_CAPTION
> +            || display() == LIST_ITEM;

What about table, box, flexbox, grid and their inline versions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.