[Webkit-unassigned] [Bug 89777] [BlackBerry] Use air controls if client doesn't support HTML control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89777





--- Comment #3 from Crystal Zhang <haizhang at rim.com>  2012-06-22 14:30:20 PST ---
(From update of attachment 149095)
View in context: https://bugs.webkit.org/attachment.cgi?id=149095&action=review

>> Source/WebKit/blackberry/Api/WebPageClient.h:163
>> +    virtual void openPopupList(bool multiple, int size, const ScopeArray<WebString>& labels, bool* enableds, const int* itemType, bool* selecteds) = 0;
> 
> "size" is a little bit vague here. Are "enableds" and "selecteds" outputs?

no, they are inputs. Actually I just put the old method back, I thought we don't need it any more so removed in previous patch.

>> Source/WebKit/blackberry/Api/WebPageClient.h:255
>> +    virtual bool createPopupWebView(Platform::IntRect) = 0;
> 
> why remove const&?

In our repo it's just Platform::IntRect, also in libwebview it's the same too. Just want to make it consistent, otherwise we need to change libwebview too.

>> Source/WebKit/blackberry/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=89777
> 
> air=>AIR?

yeah.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.