[Webkit-unassigned] [Bug 89514] Add url to supportsType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 10:25:53 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89514





--- Comment #23 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2012-06-22 10:25:50 PST ---
(In reply to comment #21)
> (From update of attachment 149044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149044&action=review
> 
> This looks great modulo the two minor issues noted. Thanks!
> 
> > Source/WebCore/ChangeLog:15
> > +        for MediaStream needs to know to URL to decide if it's supported or not.
> > +
> > +
> > +        * dom/DOMImplementation.cpp:
> 
> Minor nit: extra blank line here.
> 
> > Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:731
> > +    UNUSED_PARAM(url);
> > +
> 
> Oops, it looks like you forgot to change this one.

Thanks for the review! Can you add it to the queue?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list