[Webkit-unassigned] [Bug 89514] Add url to supportsType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 10:10:57 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89514


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149044|review?                     |review+
               Flag|                            |




--- Comment #21 from Eric Carlson <eric.carlson at apple.com>  2012-06-22 10:10:55 PST ---
(From update of attachment 149044)
View in context: https://bugs.webkit.org/attachment.cgi?id=149044&action=review

This looks great modulo the two minor issues noted. Thanks!

> Source/WebCore/ChangeLog:15
> +        for MediaStream needs to know to URL to decide if it's supported or not.
> +
> +
> +        * dom/DOMImplementation.cpp:

Minor nit: extra blank line here.

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:731
> +    UNUSED_PARAM(url);
> +

Oops, it looks like you forgot to change this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list