[Webkit-unassigned] [Bug 89639] [EFL] Change format of return value of navigator.language

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89639





--- Comment #8 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-22 02:08:13 PST ---
(From update of attachment 148958)
View in context: https://bugs.webkit.org/attachment.cgi?id=148958&action=review

> Source/WebCore/platform/efl/LanguageEfl.cpp:46
> +    return String(localeDefault).replace('_', '-').left(String(localeDefault).find('.'));

I'm a little confused to manipulate string in a line. I think it is good to use new string variable. See also, blackberry port.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp#L63

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.