[Webkit-unassigned] [Bug 86694] Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 00:28:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86694





--- Comment #18 from Yusuke Sato <yusukes at chromium.org>  2012-06-22 00:28:04 PST ---
Looks like you need to fix WebInputEventFactory::keyboardEvent() in Source/WebKit/chromium/src/win/WebInputEventFactory.cpp too:

WebKeyboardEvent WebInputEventFactory::keyboardEvent(HWND hwnd, UINT message,
                                                     WPARAM wparam, LPARAM lparam)
{
    WebKeyboardEvent result;

    // TODO(pkasting): http://b/1117926 Are we guaranteed that the message that  
    // GetMessageTime() refers to is the same one that we're passed in? Perhaps  
    // one of the construction parameters should be the time passed by the       
    // caller, who would know for sure.                                          
    result.timeStampSeconds = GetMessageTime() / 1000.0;

    result.windowsKeyCode = static_cast<int>(wparam);  // <--------------- HERE

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list