[Webkit-unassigned] [Bug 89734] run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 22:42:09 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89734





--- Comment #2 from Fumitoshi Ukai <ukai at chromium.org>  2012-06-21 22:42:08 PST ---
in webkitpy/layout_tests/ports/server_process.py
 if write failed
   -> stop()
      -> _reset()
         -> _proc = None
   -> _crashed = True

so, has_crashed() will return True.
but calling pid() would fail to access pid of None.
we should save pid before calling _reset(), so that
 pid() returns that value if _proc is None
or
 new crashed_pid() method returns that value
?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list