[Webkit-unassigned] [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89735





--- Comment #5 from Rahul Tiwari <rahultiwari.cse.iitr at gmail.com>  2012-06-21 22:18:03 PST ---
(In reply to comment #4)
> > Rahul Tiwari, I would kindly ask that you do not r+ inspector-related changes. Reviewership means that you understand the code you are reviewing.
> 
> Oh, sorry, I did not realize that you r+-ed the change for yourself. You should set it to r? so that the reviewer either converted it to r- or r+.

Thanks for the review Pavel. I will remember the review thing next time. Also, I will make the necessary changes. As for the following change:


> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:261
> +            delete this.watchExpressions[i];

> What are you trying to do here? Clearing the array?

Actually "delete this.watchExpressions[i];" only sets the 'i'th array entry to undefined, and does not physically delete it. Splicing the array is a better option. But since the existing functionality used this technique, therefore I used the same.

Please suggest me if I should let it stay the same or use splicing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.