[Webkit-unassigned] [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89735


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148959|review+                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-06-21 21:53:09 PST ---
(From update of attachment 148959)
View in context: https://bugs.webkit.org/attachment.cgi?id=148959&action=review

Rahul Tiwari, I would kindly ask that you do not r+ inspector-related changes. Reviewership means that you understand the code you are reviewing.

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:258
> +    deleteAllExpressions: function()

This should be declared private.

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:261
> +            delete this.watchExpressions[i];

What are you trying to do here? Clearing the array?

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:274
> +    expressionCount: function()

should be private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.