[Webkit-unassigned] [Bug 89724] Make HTMLDocumentParser::create(DocumentFragment*, Element*, FragmentScriptingPermission) private.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 19:50:18 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89724


Kwang Yul Seo <skyul at company100.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Kwang Yul Seo <skyul at company100.net>  2012-06-21 19:50:17 PST ---
(In reply to comment #2)
> (From update of attachment 148932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review
> 
> > Source/WebCore/html/parser/HTMLDocumentParser.h:93
> > +    // Used by parseDocumentFragment
> 
> Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date.
> 
> Also, there is a missing period here, since we use sentence style for comments.

I removed the comment and landed the patch manually. Thanks.

http://trac.webkit.org/changeset/120997

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list