[Webkit-unassigned] [Bug 89719] [EFL] ProcessExecutablePath is required

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89719


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148924|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-21 19:48:12 PST ---
(From update of attachment 148924)
View in context: https://bugs.webkit.org/attachment.cgi?id=148924&action=review

> Source/WebKit2/ChangeLog:8
> +        Added ProcessExecutablePathEfl.cpp for EFL.

Meaningless patch description. Please write more meaningful description.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:23
> +#include <libgen.h>

This functions only can be used on linux platform. So, use #if OS(LINUX)

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:28
> +const char* gWebKitWebProcessName = "WebProcess";

I prefer to use "static const char*" for constant variable.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:37
> +    ssize_t result = readlink("/proc/self/exe", readLinkBuffer, PATH_MAX);

ditto. By the way, personally, I think EFL port also need to implement utility functions like GTK port in future.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:40
> +        executablePath = String("/usr/bin");

It is good to make constant variable for default path. See also, GTK port use LIBEXECDIR macro.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:46
> +    String fullPath = executablePath + "/" + processName;

If possible, use makeString(), pathByAppendingComponent() or WebKit utilities functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.