[Webkit-unassigned] [Bug 89244] Web Inspector: Add data length to resource events on timeline to keep track of the amount of data loaded and the total data length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89244


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148881|review?                     |review-
               Flag|                            |




--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2012-06-21 18:24:32 PST ---
(From update of attachment 148881)
View in context: https://bugs.webkit.org/attachment.cgi?id=148881&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:799
> +            var contentLength = this._presentationModel._contentLengthByRequestId[record.data["requestId"]];

You should not access private fields defined in other files.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:196
> +        this._networkLoadedDataLength = {};

I don't think we really need all these details in the Timeline.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:197
> +        this._contentLengthByRequestId = {};

ditto

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:537
> +                if (this.data["length"])

I would leave only these two lines that are providing the actual instrumented data.

> LayoutTests/inspector/timeline/timeline-network-received-data-expected.txt:6
> +ResourceReceivedData Properties:

This test might get flaky: what if there are multiple received data entries... You should check that there is at least one received data entry and that it has length instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.