[Webkit-unassigned] [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88268





--- Comment #28 from Dave Tu <dtu at chromium.org>  2012-06-21 15:29:43 PST ---
(In reply to comment #26)
> (From update of attachment 148706 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148706&action=review
> 
> > Source/Platform/chromium/public/WebRenderingStats.h:56
> > +    WebSerializedScriptValue value()
> > +    {
> > +        v8::Handle<v8::Object> stats = v8::Object::New();
> > +        if (numAnimationFrames)
> > +            stats->Set(v8::String::New("numAnimationFrames"),
> > +                              v8::Integer::New(numAnimationFrames),
> > +                              v8::ReadOnly);
> > +        if (numFramesSentToScreen)
> > +            stats->Set(v8::String::New("numFramesSentToScreen"),
> > +                              v8::Integer::New(numFramesSentToScreen),
> > +                              v8::ReadOnly);
> > +        return WebSerializedScriptValue::serialize(stats);
> > +    }
> 
> I don't undertand why this function is here.  This doesn't look right.

It's here because we plan on adding a bunch of additional fields to WebRenderingStats in the future, and moving the v8 object creation into WebKit allows us to do that without any changes on the Chromium side, as in https://chromiumcodereview.appspot.com/10536080/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.