[Webkit-unassigned] [Bug 89517] Web Inspector: ExtensionPanel.onSearch listener doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89517





--- Comment #8 from Jan Keromnes <janx at chromium.org>  2012-06-21 14:20:30 PST ---
(In reply to comment #6)
> dumpObject(Array.prototype.slice.call(arguments)) -- this will take care of all the arguments in case we accidentally add any.

Fixed.

> > LayoutTests/inspector/extensions/extensions-panel.html:92
> > +            if (callbackCount == 2)
> 
> == => ===

Also fixed.

> > LayoutTests/inspector/extensions/extensions-panel.html:116
> > +    function performSearch()
> > +    {
> > +        evaluateOnFrontend("WebInspector.searchController._performSearch('hello', true, false, false); reply()");
> > +    }
> >      // The panel code is expected to report its size via InspectorTest.panelCallback()
> > -    evaluateOnFrontend("InspectorTest.waitForPanel(reply);", nextTest);
> > +    evaluateOnFrontend("InspectorTest.waitForPanel(reply);", performSearch);
> 
> This could be a separate test (in fact, show() could also be separate).

I actually tried to place it in another test, but as _performSearch has no callback, the tests were flaky. Putting the tests back together was the only way I found to resolve that flakiness issue, and without creating several test panels.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.