[Webkit-unassigned] [Bug 89678] Web Inspector: Support 'Restart frame' in inspector frontend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89678


Peter Rybin <prybin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148840|1                           |0
        is obsolete|                            |




--- Comment #5 from Peter Rybin <prybin at chromium.org>  2012-06-21 12:34:25 PST ---
(From update of attachment 148840)
View in context: https://bugs.webkit.org/attachment.cgi?id=148840&action=review

>> Source/WebCore/inspector/front-end/DebuggerModel.js:552
>> +    callStackModified: function(newCallFrames, details) {
> 
> { on the next line

Done

>> Source/WebCore/inspector/front-end/DebuggerModel.js:554
>> +        if (details && details["stack_update_needs_step_in"]) {
> 
> No need for { } for the upper branch

Done. Could have done for the lower branch as well.

>> Source/WebCore/inspector/front-end/DebuggerModel.js:555
>> +            DebuggerAgent.stepInto();
> 
> You should do this in the backend.

It's a tricky thing. This would make command optionally changing backend state from paused to resumed. Let's not do it right now.

>> Source/WebCore/inspector/front-end/DebuggerModel.js:740
>> +            if (!error) {
> 
> no need for { }

Done

>> Source/WebCore/inspector/front-end/DebuggerModel.js:743
>> +            if (callback) {
> 
> ditto

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.