[Webkit-unassigned] [Bug 89517] Web Inspector: ExtensionPanel.onSearch listener doesn't work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 13:53:07 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89517





--- Comment #6 from Andrey Kosyakov <caseq at chromium.org>  2012-06-21 13:53:05 PST ---
(From update of attachment 148857)
View in context: https://bugs.webkit.org/attachment.cgi?id=148857&action=review

> LayoutTests/inspector/extensions/extensions-panel.html:87
> +            dumpObject({

dumpObject(Array.prototype.slice.call(arguments)) -- this will take care of all the arguments in case we accidentally add any.

> LayoutTests/inspector/extensions/extensions-panel.html:92
> +            if (callbackCount == 2)

== => ===

> LayoutTests/inspector/extensions/extensions-panel.html:116
> +    function performSearch()
> +    {
> +        evaluateOnFrontend("WebInspector.searchController._performSearch('hello', true, false, false); reply()");
> +    }
>      // The panel code is expected to report its size via InspectorTest.panelCallback()
> -    evaluateOnFrontend("InspectorTest.waitForPanel(reply);", nextTest);
> +    evaluateOnFrontend("InspectorTest.waitForPanel(reply);", performSearch);

This could be a separate test (in fact, show() could also be separate).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list