[Webkit-unassigned] [Bug 89244] Web Inspector: Add data length to resource events on timeline to keep track of the amount of data loaded and the total data length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89244


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148872|review?                     |review-
               Flag|                            |




--- Comment #13 from Rob Buis <rwlbuis at gmail.com>  2012-06-21 13:34:59 PST ---
(From update of attachment 148872)
View in context: https://bugs.webkit.org/attachment.cgi?id=148872&action=review

Looks good, some small stuff to fix still.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:415
> +        if (record.type === recordTypes.ResourceFinish)

Could add else here.

> LayoutTests/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

Reviewed by should be first, then empty line, then description.

> LayoutTests/inspector/timeline/timeline-network-received-data.html:38
> +            if (record.type === WebInspector.TimelineModel.RecordType.ResourceReceivedData){

Add space between ')' and '{'.

> LayoutTests/inspector/timeline/timeline-network-received-data.html:40
> +}

Please indent properly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.