[Webkit-unassigned] [Bug 89244] Web Inspector: Add progress events to the timeline to keep track of how much the main frame has loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89244


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148850|review?                     |review-
               Flag|                            |




--- Comment #11 from Rob Buis <rwlbuis at gmail.com>  2012-06-21 12:39:43 PST ---
(From update of attachment 148850)
View in context: https://bugs.webkit.org/attachment.cgi?id=148850&action=review

Looks good but ChangeLog can be improved.

> Source/WebCore/ChangeLog:5
> +         keep track of the amount of data loaded.

This seems wrong, you should just put the bug title here.

> Source/WebCore/ChangeLog:9
> +

You can move the above description to here.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:543
> +                }

Inconsistent use of braces, I'd advise not using braces for this if section.

> LayoutTests/ChangeLog:4
> +        timeline network received data event.

Just state bug title here.

> LayoutTests/ChangeLog:8
> +

You can move the above description to here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.