[Webkit-unassigned] [Bug 89583] BlackBerry port does not sanitize GLSL code with ANGLE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89583





--- Comment #3 from Konrad Piascik <kpiascik at rim.com>  2012-06-21 11:36:14 PST ---
(From update of attachment 148619)
View in context: https://bugs.webkit.org/attachment.cgi?id=148619&action=review

I don't know enough about the affected files to provide a full review but these style issues should be fixed.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

you need to specify what changes were made.  The bug title is not descriptive enough to describe what changes are needed in all these files.

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

> Source/WebKit/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

> Source/WebCore/platform/graphics/GraphicsContext3D.h:82
> +#if (PLATFORM(CHROMIUM) && USE(SKIA))

There shouldn't be a need to add these brackets

> ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.