[Webkit-unassigned] [Bug 88654] SVG filter's SourceGraphic is clipped to the screen size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88654


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146847|review?                     |review-
               Flag|                            |




--- Comment #12 from Dirk Schulze <krit at webkit.org>  2012-06-21 10:53:19 PST ---
(From update of attachment 146847)
View in context: https://bugs.webkit.org/attachment.cgi?id=146847&action=review

This patch is missing some more detailed description of the intention. r- because of the missing description.

>>> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:251
>>> +    rect = IntRect(IntPoint(), sourceGraphic->logicalSize());
>> 
>> Could we just use an IntSize instead of an IntRect? Does this out arg ever need to carry anything other than a size?
> 
> Could we just use an IntSize instead of an IntRect? Does this out arg ever need to carry anything other than a size?

The passed argument is a rect, how do you want to change that? I just don't understand why you set this rect. Usually you should not do that. paintInfo gives you the  information of the screen. I assume that you want to limit the painted content to the size of the source graphic some how? But again, what is the intention. Do you want to make sure that the source graphic covers everything that the filter region need?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.