[Webkit-unassigned] [Bug 89514] Add url to supportsType

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89514





--- Comment #12 from Eric Carlson <eric.carlson at apple.com>  2012-06-21 10:07:56 PST ---
(From update of attachment 148780)
View in context: https://bugs.webkit.org/attachment.cgi?id=148780&action=review

> Source/WebCore/ChangeLog:12
> +        When a blob is created as the address for a Media Stream, the MediaEngine
> +        will ask it's players if they support that media. However, a player built
> +        for MediaStream needs to know to URL to decide if it's or it's not supported.

Nit: "if it's or it's not supported" is slightly awkward, I suggest something like "if it is supported or not"

> Source/WebCore/platform/graphics/MediaPlayer.h:426
> +typedef MediaPlayer::SupportsType (*MediaEngineSupportsType)(const String& type, const String& codecs, const String& keySystem, const String& url);

Why not pass the url as a KURL rather than as a string?

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:731
> +MediaPlayer::SupportsType MediaPlayerPrivateAVFoundationCF::supportsType(const String& type, const String& codecs, const String& url)
>  {
> +    UNUSED_PARAM(url);
> +

The "UNUSED_PARAM()" will be unnecessary if you leave out the parameter name, e.g.. const String& codecs, const String&)

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:678
> +MediaPlayer::SupportsType MediaPlayerPrivateAVFoundationObjC::supportsType(const String& type, const String& codecs, const String& url)
>  {
> +    UNUSED_PARAM(url);
> +

Ditto here and throughout the rest of the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.