[Webkit-unassigned] [Bug 88663] Renamed DeviceOrientation to DeviceOrientationData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88663





--- Comment #26 from Alexey Proskuryakov <ap at webkit.org>  2012-06-21 09:14:03 PST ---
> > Seeing that there is also a "DeviceOrientationController" class, the whole subsystem likely needs a rewrite anyway.
> 
> Out of interest, why do you say this? When Geolocation was re-written a while back, it adopted Geolocation/GeolocationController/GeolocationClient naming and I thought this was an accepted pattern?

I'm saying this because in object oriented programming, "data" and "controller" classes are almost always a sign of poorly done job. A class is supposed to encapsulated data and behaviors, and to match a domain concept of "object".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.