[Webkit-unassigned] [Bug 89660] [GTK] Add support for graphviz debug output for the gstreamer video pipeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89660


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148794|                            |commit-queue-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2012-06-21 08:39:37 PST ---
(From update of attachment 148794)
View in context: https://bugs.webkit.org/attachment.cgi?id=148794&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:799
> +            // Construct a filename for the graphviz dot file output

Nit: You're missing a period at the end of this sentence.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:801
> +            dotFileName = g_strdup_printf("webkit-video.%s_%s", gst_element_state_get_name(oldState), gst_element_state_get_name(newState));

It's probably better to use 

CString dotFileName = String::format("webkit-video.%s_%s", gst_element_state_get_name(oldState), gst_element_state_get_name(newState)).utf8();

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:803
> +            GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_playBin), GST_DEBUG_GRAPH_SHOW_ALL, dotFileName);

This would become:
GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_playBin), GST_DEBUG_GRAPH_SHOW_ALL, dotFileName.data());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.