[Webkit-unassigned] [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 08:21:26 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89666





--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-06-21 08:21:25 PST ---
Attachment 148807 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/WebKitTestRunner/qt/TestControllerQt.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/WebKitTestRunner/qt/TestControllerQt.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56:  Use 0 instead of NULL.  [readability/null] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit2/Shared/qt/QtDefaultDataLocation.h:38:  The parameter name "dataLocation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/qt/QtDefaultDataLocation.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 8 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list