[Webkit-unassigned] [Bug 88654] svgfilter sourcegraphic is clipped out according to the screen rectangle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88654





--- Comment #10 from Tim Horton <timothy_horton at apple.com>  2012-06-21 01:22:04 PST ---
(From update of attachment 146847)
View in context: https://bugs.webkit.org/attachment.cgi?id=146847&action=review

> LayoutTests/ChangeLog:3
> +        svgfilter sourcegraphic is clipped out according to the screen rectangle

Let's fix up the title a little. I'll fix the bug's title if you update it here :D

> LayoutTests/ChangeLog:7
> +

This could use a minor explanation "Add a test to ensure that [whatever you're testing]".

> LayoutTests/svg/filters/large-filtered-SVGImage.svg:3
> +    <filter id="test" filterUnits="objectBoundingBox" x="0" y="0" width="1" height="1">

Perhaps make the filter's id something more descriptive (translateImageFilter?) than "test".

> Source/WebCore/ChangeLog:3
> +        svgfilter sourcegraphic is clipped out according to the screen rectangle

Ditto on the title.

> Source/WebCore/ChangeLog:7
> +

This *definitely* needs more explanation of what you changed and why.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:251
> +    rect = IntRect(IntPoint(), sourceGraphic->logicalSize());

Could we just use an IntSize instead of an IntRect? Does this out arg ever need to carry anything other than a size?

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:77
> +        UNUSED_PARAM(resourceMode);

You can leave the name of the resourceMode parameter off above instead of UNUSED_PARAM'ing it.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:83
> +        UNUSED_PARAM(resourceMode);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.