[Webkit-unassigned] [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88665


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148697|review?                     |review-
               Flag|                            |




--- Comment #26 from Hajime Morrita <morrita at google.com>  2012-06-20 21:36:06 PST ---
(From update of attachment 148697)
View in context: https://bugs.webkit.org/attachment.cgi?id=148697&action=review

The code is over-commented. We can get rid of most of them.

On linker errors, you need to export some symbols which is referred from the Internals object.
See http://trac.webkit.org/changeset/120684 as an example.
WebCore.exp.in, WebKit2.def, symbols.fitter are such files.

> Source/WebCore/dom/Document.cpp:4877
> +    // Ensure URL is not already in the list before adding it.

This comment can be removed.

> Source/WebCore/testing/Internals.h:185
> +    PassRefPtr<DOMStringList> dumpIconURLs(Document*) const;

"dump" is redundant.

> Source/WebKit/chromium/public/WebFrame.h:-148
> -    virtual WebVector<WebIconURL> iconURLs(int iconTypes) const = 0;

I don't think we need to change this const-ness.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.