[Webkit-unassigned] [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 18:13:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88665


Pete Williamson <petewil at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148601|0                           |1
        is obsolete|                            |
 Attachment #148601|review?                     |
               Flag|                            |
 Attachment #148697|                            |review?
               Flag|                            |




--- Comment #22 from Pete Williamson <petewil at chromium.org>  2012-06-20 18:13:18 PST ---
Created an attachment (id=148697)
 --> (https://bugs.webkit.org/attachment.cgi?id=148697&action=review)
Patch with a proposed fix for the bug (with layout tests, more recently synced, no extra files, better style)

Slight changes to approach based on CR feedback.  
We now always calculate the URL list.
We changed the way we build the list of IconURLs to be a bit simpler(using the existing KURL instead of making a new one, less string manipulation)
We now use a list of URLs in the Internals method instead of a big concatenated string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list