[Webkit-unassigned] [Bug 89366] FastMalloc.cpp needs to be reordered before padding bug can be fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 14:46:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89366





--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-20 14:46:22 PST ---
(In reply to comment #14)
> Either way, there is going to be a big patch.  We need to move code that is not following webkit style, which means that it needs to be formatted into webkit style to be committed.  This means changing variable names from variables with underscores, which must be changed everywhere the variable is used.  This quickly makes it so I have to reformat the whole file, which I did.
> 
> It was quite tedious, but it should be easy to check.  Just use kdiff3 or something similar.  Most of the changes are spaces or variable names.

A preferred approach for a big move like this is to fix all styles in one patch, move all code on the second patch, then fix the code on the third patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list