[Webkit-unassigned] [Bug 89573] New: wevkit-patch can't handle if there are more than one "Reviewed by NOBODY (OOPS!)." line in the changelog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89573

           Summary: wevkit-patch can't handle if there are more than one
                    "Reviewed by NOBODY (OOPS!)." line in the changelog
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: eric at webkit.org, abarth at webkit.org,
                    galpeter at inf.u-szeged.hu, dpranke at chromium.org,
                    rniwa at webkit.org, kkristof at inf.u-szeged.hu,
                    bank at inf.u-szeged.hu


This bug is revealed by https://bugs.webkit.org/show_bug.cgi?id=67935

https://bugs.webkit.org/attachment.cgi?id=148323&action=review was reviewed by rniwa,
and cq couldn't land the patch. We tried to apply it with webkit-patch apply-attachment
and apply-from-bug, but webkit-patch replaced only the first occurance of "Reviewed by NOBODY ..."

We don't know why ... The following code should replace all, but it doesn't do it.
I'm sure that replacing all "NOBODY (OOPS!)" wouldn't be the correct behaviour,
but this code shouldn't work as it works now. :)

http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py#L347
353                for line in fileinput.FileInput(self.path, inplace=1):
354                    # Trailing comma suppresses printing newline
355                    print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")),

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.