[Webkit-unassigned] [Bug 88580] RenderObject should not know about first-line element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88580





--- Comment #7 from Igor Trindade Oliveira <igor.oliveira at webkit.org>  2012-06-20 08:05:48 PST ---
I am just moving the methods uncachedFirstLineStyle and firstLineStyleSlowCase out of the RenderObject, however doing that i need to change the code in lot of places, specially because RenderObject::style(bool) is also called by RenderText object, so in some cases i need to do:

renderObject->isText() ? toRenderBoxModelObject(renderObject->parent())->firstLineStyle() : toRenderBoxModelObject(renderObject)->firstLineStyle();

This code is valid because firstLineStyleSlowCase() already does:

const RenderObject* renderer = isText() ? parent() : this;

In other parts of the code, i agree that probably the casts are not correctly(e.g. getTextDecorartion) but i am fixing case by case.

(In reply to comment #6)
> (In reply to comment #0)
> > RenderObject has some code related with first-line. This code should be in RenderBlockLineLayout or RenderBoxModelObject.
> 
> I support the idea of ripping subclass-specific code out of RenderObject, but it's not clear to me what you're trying to do here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.