[Webkit-unassigned] [Bug 89572] Breaking LayoutUnits down to ints for baseline position and ascents needs rounding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89572





--- Comment #2 from Emil A Eklund <eae at chromium.org>  2012-06-20 08:02:04 PST ---
(In reply to comment #0)
> In my understanding, the reason is the default toInt() of LayoutUnit being called when the RenderBlock::baselinePosition() is assigned to ascent values in 
> RootInlineBox::ascentAndDescentForBox. If we consistently use rounding here, I can get the test failures on EFL down from initially around 3800 to 563.

Good catch, it really seems we should fix that.

>My understanding is still limited - but I guess that the proper fix would be to also transition all the ascent/descent/maxAscent/maxDescent calculations to LayoutUnits and round later? Is that something that you're planning to do, Levi & Emil?

Yes, we plan to transition ascent/descent to LayoutUnits once the majority of the ports has enabled subpixel layout.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.