[Webkit-unassigned] [Bug 89559] Web Inspector: handling enter key bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89559


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148546|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-06-20 06:55:55 PST ---
(From update of attachment 148546)
View in context: https://bugs.webkit.org/attachment.cgi?id=148546&action=review

> Source/WebCore/ChangeLog:3
> +        Fixing Bug 89559 - Web Inspector: handling enter key bug

Patch should start with the bug title.

> Source/WebCore/ChangeLog:5
> +        Web Inspector: handling enter key bug

This bug title is too vague, please be more specific

> Source/WebCore/ChangeLog:12
> +        The person who fixed Bug 71625 forgot to use result of his own method.

We typically say "Regressed in rXXXX" where XXXX is a revision number. That should be mentioned in the bug description.

> Source/WebCore/inspector/front-end/TextViewer.js:1254
>          this._exitTextChangeMode(range, newRange);

You should call exitTextChangeMode with exact newRange that editRange returned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.