[Webkit-unassigned] [Bug 89514] Add url to supportsType

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89514


Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|New Bugs                    |Media Elements




--- Comment #8 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2012-06-20 06:13:08 PST ---
(In reply to comment #4)
> (From update of attachment 148427 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148427&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +        In the case of two media players where one is used for MediaStream, it needs to know the URL to check if it's
> > +        a MediaStream generated blob, to return if it's supported or not.
> 
> I don't understand this. Please elaborate.

When the user calls webkitGetUserMedia it will create a blob specific for that stream.

On GTK we've created an StreamMediaPlayer to be used for the propose of playing rtp streams created by the mediastream call, however we're having issues on how to identify if we should use this player or the gstreamer one, since the MediaPlayerPrivateInterface::supportsType(type,codec) doesn't have access to the media's url.

With this patch the new player will be able to identify if the media is a mediastream blob created by us (using MediaStreamRegistry::registry().lookupMediaStreamDescriptor(url)), and then return MediaPlayer::IsSupported;

While the players that don't implement MediaStream or those using the same player could just ignore that.

> 
> > Source/WebCore/ChangeLog:13
> > +        No new tests since there's no change on code behavior.
> 
> If there is no change in behavior, why is the code change necessary?

Since basically the current ports will just ignore the parameter, I initially thought that no tests would be necessary. But since it modifies the MediaPlayer API I'll check which tests need to be changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.